[EdLUG] Misc comments - 08 July't see

[Andrew Ramage]

Thank you.  I couldn't see the missing bracket for looking ...

On 10/07/2020 22:15, Jeremy Nicoll wrote:

> On Fri, 10 Jul 2020, at 20:08, Andrew Ramage wrote:
>> I don't know how to start a page from another unless it's a form.  (Like
>> I currently use.)  I _do_ use a syntax highlighting erroreditor.  I
>> think it was a copy&paste error.  I got the page working, but the <? php
>> include statements did not.  So I wrote the functions to replace them.
> What do those include statements look like?  Did they ever work?
>
>
> You didn't answer this much more fundamental question:
>
>> ... but discovered that the php processor wasn't loaded
>>> What do you mean?   How did you discover that?
> I think that whatever was really going on then is more likely the
> problem than "php wasn't loaded" which - as I said - cannot be
> the problem.
>
> I wonder if the error message perhaps said that a file you'd tried
> to include hadn't been loaded (which probably means no such
> file)?
>
>
>
> I've said to you several times that the norm on login pages is either to
> produce error messages for why a login hasn't worked, or positive
> messages welcoming the user, then provide a link for them to click
> after they have read the welcome.  I think the reason this is done may
> be that that's simpler than trying to do a nextpage() thing.  Browsers
> do not normally go to another page without the user clicking something.
>
> But even if your method is to be used, what I don't understand is why
> when you open and read the page2.php file, you then test whether
> lines in it are one thing or another.  You already know what the lines
> in it are, because you wrote them.
>
> Do those tests etc actually work?  I'd have expected
>
>    if ($line == "<?php include 'Directory/errors.html';?>" {
>
> never to be true.   Why?  Because as you found out reading the
> passwords file, the $line value will surely include a trailing newline
> character.
>
> Also there's a missing closing bracket on that if ()     and likewise in
> this one
>
>      if ($line == '<?php include "books.html"?>' {
>
>   
> If I try to fetch these files:
>
> http://andrewnramage.co.uk/books.html      that works but
>
> http://andrewnramage.co.uk/Directory/directory.html        this fails
> http://andrewnramage.co.uk/Directory/errors.html            this fails
>
> http://andrewnramage.co.uk/login_dev.php
>
> I get a syntax error on line 37 - unepected semicolon.  That might be
> the missing closing brackets.
>
>
-- 
Visit my Website: www.andrewnramage.co.uk